Use a single-line title bar for every Android destination #5

Open
salix wants to merge 2 commits from fix/android-top-bar-spacing into main
Owner

What & why

On a phone the destination screens opened under a 152 dp expanding title — about a fifth of the screen held before the first scroll, naming a destination the bottom navigation bar already labels. Every destination now uses the single-line bar in every layout, as the two-pane layouts already did; the collapsing scroll-behaviour plumbing around the large title goes with it.

Before After
before after

Verify

  • ./gradlew :app:testDebugUnitTest -Pferry.screenshots=verify --tests '*Screenshots*' — the four phone destination references are re-recorded; every other scene renders pixel-identical.
  • ./gradlew :app:compileDebugKotlin :app:lintDebug :app:testDebugUnitTest — compile, lint (0 errors) and all 187 app JVM tests pass.
## What & why On a phone the destination screens opened under a 152 dp expanding title — about a fifth of the screen held before the first scroll, naming a destination the bottom navigation bar already labels. Every destination now uses the single-line bar in every layout, as the two-pane layouts already did; the collapsing scroll-behaviour plumbing around the large title goes with it. | Before | After | |---|---| | ![before](https://git.salix.host/attachments/0e3a91d2-b56b-4390-a40a-79df43549006) | ![after](https://git.salix.host/attachments/3bf6c3c4-0aeb-462a-af23-ade1155954be) | ## Verify - `./gradlew :app:testDebugUnitTest -Pferry.screenshots=verify --tests '*Screenshots*'` — the four phone destination references are re-recorded; every other scene renders pixel-identical. - `./gradlew :app:compileDebugKotlin :app:lintDebug :app:testDebugUnitTest` — compile, lint (0 errors) and all 187 app JVM tests pass.
Use a single-line title bar for every Android destination
All checks were successful
Build Android nightly and check shared core / android (pull_request) Successful in 25m49s
e73afdc63d
Merge branch 'main' into fix/android-top-bar-spacing
All checks were successful
Build Android nightly and check shared core / android (pull_request) Successful in 13m12s
2edcabd70b
All checks were successful
Build Android nightly and check shared core / android (pull_request) Successful in 13m12s
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/android-top-bar-spacing:fix/android-top-bar-spacing
git switch fix/android-top-bar-spacing

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff fix/android-top-bar-spacing
git switch fix/android-top-bar-spacing
git rebase main
git switch main
git merge --ff-only fix/android-top-bar-spacing
git switch fix/android-top-bar-spacing
git rebase main
git switch main
git merge --no-ff fix/android-top-bar-spacing
git switch main
git merge --squash fix/android-top-bar-spacing
git switch main
git merge --ff-only fix/android-top-bar-spacing
git switch main
git merge fix/android-top-bar-spacing
git push origin main
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
salix/ferry!5
No description provided.