salix/madre
1
0
Fork 0
Code Issues Pull requests 2 Projects Releases 1 Packages Wiki Activity Actions 2

Make the send icon visible in every style #4

Open
salix wants to merge 1 commit from fix/invisible-send-icon into main
pull from: fix/invisible-send-icon
merge into: salix:main
Conversation 0 Commits 1 Files changed 4 +15 -3
salix commented 2026-10-19 10:56:40 +02:00
Owner
Copy link

What & why

The send icon next to the upload board's “Send” chip was invisible on the light style: its light variant shipped as a white copy of the dark one, drawing white-on-white. This PR gives it the ink color every other light icon uses, and adds a style-independent white accent variant for the composer's accent-filled send button, which needs white in both styles.

Screenshots are mocks of the upload board (the popup that appears when you attach media), styled from the app's own CSS values; the chip icon is the real SVG resource at its real 12 px size. Not app captures.

Before After
before: Send chip icon invisible after: Send chip icon visible

Verify

  • cargo check -p madre — compiles and bundles the new themed-accent-send-symbolic.svg resource
  • Light style: the icon next to the upload board's “Send” chip is visible (dark ink), and the round composer button still shows a white icon on the accent color; both hold in dark style
## What & why The send icon next to the upload board's “Send” chip was invisible on the light style: its light variant shipped as a white copy of the dark one, drawing white-on-white. This PR gives it the ink color every other light icon uses, and adds a style-independent white accent variant for the composer's accent-filled send button, which needs white in both styles. Screenshots are mocks of the upload board (the popup that appears when you attach media), styled from the app's own CSS values; the chip icon is the real SVG resource at its real 12 px size. Not app captures. | Before | After | |---|---| | ![before: Send chip icon invisible](https://git.salix.host/attachments/e2ddec87-f0d4-4ad3-be4e-d4cdfb0d6c4d) | ![after: Send chip icon visible](https://git.salix.host/attachments/a6b94371-c773-4ceb-85f4-7667be1c4c97) | ## Verify - `cargo check -p madre` — compiles and bundles the new `themed-accent-send-symbolic.svg` resource - Light style: the icon next to the upload board's “Send” chip is visible (dark ink), and the round composer button still shows a white icon on the accent color; both hold in dark style
before.png
33 KiB
after.png
33 KiB
Make the send icon visible in every style
All checks were successful
Build x86_64 Flatpak / flatpak (pull_request) Successful in 9m44s
Details
ed4eac0bfd 
The send icon's light variant was a byte-for-byte copy of the dark
one: white fill and stroke. On the light window background the
upload board's "Send" chip therefore drew an invisible white icon,
showing its accent label with nothing beside it.

Give the light variant the ink color (#2e3436) the other light
icons use. That alone would have turned the icon dark on the
composer's accent-filled send button, which needs white in both
styles, so add a third, style-independent accent variant
(themed-accent-send-symbolic.svg) with an icons::accent() helper,
and point the composer send button at it.

The lock pair is also identical across styles, but deliberately so:
it is a dim gray indicator in both.
All checks were successful
Build x86_64 Flatpak / flatpak (pull_request) Successful in 9m44s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/invisible-send-icon:fix/invisible-send-icon
git switch fix/invisible-send-icon

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff fix/invisible-send-icon
git switch fix/invisible-send-icon
git rebase main
git switch main
git merge --ff-only fix/invisible-send-icon
git switch fix/invisible-send-icon
git rebase main
git switch main
git merge --no-ff fix/invisible-send-icon
git switch main
git merge --squash fix/invisible-send-icon
git switch main
git merge --ff-only fix/invisible-send-icon
git switch main
git merge fix/invisible-send-icon
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
salix/madre!4
No description provided.