salix/invio
1
0
Fork 0
Code Issues Pull requests Projects Releases 17 Packages 1 Wiki Activity Actions 3

adwaita: finish responsive watch sheets and mini-player dragging #3

Merged
salix merged 1 commit from t3code/responsive-adwaita-sheets-miniplayer into main 2026-10-02 12:47:54 +02:00
Conversation 0 Commits 1 Files changed 7 +513 -59
salix commented 2026-10-02 12:41:05 +02:00
Owner
Copy link

When the Watch page is narrow, comments and descriptions open in scrolling bottom sheets sized to keep the video visible. Add a Description button, restore inline content when widening the window, preserve expanded descriptions when metadata arrives, and expose Read more for truncated comments. Escape dismisses sheets, and entering fullscreen closes them.

Mini-player dragging starts after the movement threshold, leaves buttons and the scrubber usable, stays within the header and navigation bounds, and snaps to a corner on release or cancellation.

Validation:

  • Native GTK sheet test passed under Xvfb at 390×844, 390×600, 768×600, and 360×360, with restoration to the 1100×844 desktop layout. Checked scrolling, metadata updates, comment expansion, Escape dismissal, and screenshots.
  • Native compact navigation/mini-player test passed, including control exclusion, clamping, snapping, cancellation, and resizing at widths of 320, 390, and 1100.
  • Targeted rustfmt checks and git diff --check passed.
  • Broader suite run: 283 passed, 2 failed, 3 ignored. The rebuffering timing test passed on an isolated rerun. The unchanged audio volume timing test still exceeds its 200 ms deadline (volume_changes_reach_playing_output_without_a_second_of_queued_audio).
When the Watch page is narrow, comments and descriptions open in scrolling bottom sheets sized to keep the video visible. Add a Description button, restore inline content when widening the window, preserve expanded descriptions when metadata arrives, and expose Read more for truncated comments. Escape dismisses sheets, and entering fullscreen closes them. Mini-player dragging starts after the movement threshold, leaves buttons and the scrubber usable, stays within the header and navigation bounds, and snaps to a corner on release or cancellation. Validation: - Native GTK sheet test passed under Xvfb at 390×844, 390×600, 768×600, and 360×360, with restoration to the 1100×844 desktop layout. Checked scrolling, metadata updates, comment expansion, Escape dismissal, and screenshots. - Native compact navigation/mini-player test passed, including control exclusion, clamping, snapping, cancellation, and resizing at widths of 320, 390, and 1100. - Targeted rustfmt checks and git diff --check passed. - Broader suite run: 283 passed, 2 failed, 3 ignored. The rebuffering timing test passed on an isolated rerun. The unchanged audio volume timing test still exceeds its 200 ms deadline (`volume_changes_reach_playing_output_without_a_second_of_queued_audio`).
adwaita: finish responsive watch sheets and mini-player dragging
All checks were successful
Build x86_64 Flatpak / flatpak (pull_request) Successful in 3m51s
Details
02930a7d2e
salix merged commit db2474340f into main 2026-10-02 12:47:54 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
salix/invio!3
No description provided.